Re: [PATCH 1/5] dt-bindings: irq: Add Qualcomm MSM VIC binding

[Krzysztof Kozlowski]

On 15/03/2026 12:17, j0sh1x wrote:
> Signed-off-by: j0sh1x <aljoshua.hell@xxxxxxxxx>

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

> ---
>  .../interrupt-controller/qcom,msm-vic.yaml    | 72 +++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/qcom,msm-vic.yaml
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,msm-vic.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,msm-vic.yaml
> new file mode 100644
> index 000000000000..5bf281f72fe0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,msm-vic.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# qualcomm,msm-vic.yaml - Device Tree binding for Qualcomm MSM VIC interrupt controller
> +
> +description: >
> +  Qualcomm MSM VIC (Vector Interrupt Controller). This interrupt controller
> +  handles normal and wakeup interrupts and supports mapping to the
> +  Qualcomm SMSM system.
> +
> +compatible: ["qcom,msm-vic"]
> +
> +properties:
> +  interrupt-controller:
> +    description: "Identifies this node as an interrupt controller"
> +    required: true
> +    type: boolean
> +
> +  #interrupt-cells:
> +    description: "Specifies the number of cells needed to encode an interrupt"
> +    required: true
> +    type: integer
> +    default: 1

I don't know what you wrote, but this is not a DT binding. Don't send us
LLM microslop products. Read first docs guiding you what you have to do.

Also, nothing here was tested.

NAK

Best regards,
Krzysztof