Re: [PATCH 1/5] dt-bindings: irq: Add Qualcomm MSM VIC binding

[Krzysztof Kozlowski]

On 16/03/2026 09:29, Krzysztof Kozlowski wrote:
> On 15/03/2026 12:17, j0sh1x wrote:
>> Signed-off-by: j0sh1x <aljoshua.hell@xxxxxxxxx>
> 
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
> 
> Please kindly resend and include all necessary To/Cc entries.
> 

Also, please go through comments here:
https://sashiko.dev/#/patchset/20260315111705.118544-1-aljoshua.hell%40gmail.com

At least the one about header was kind of right:

"Headers in include/dt-bindings/ are typically meant to define the
stable ABI between device tree sources and the OS. Exposing internal
hardware register offsets and software flags here might pollute the
globally visible DT namespace."

Best regards,
Krzysztof