Re: [PATCH] KVM: PPC: remove unnecessary #ifdef

From: Madhavan Srinivasan

Date: Sat Nov 21 2026 - 23:08:38 EST


++linuxppc-dev

On 11/20/26 7:04 PM, Paolo Bonzini wrote:
booke.o is only built as part of kvm-e500-objs (which is conditional
on $(CONFIG_KVM_E500V2)) or kvm-e500mc-objs (likewise conditional
on $(CONFIG_KVM_E500MC)). Thus, the #ifdef in kvmppc_core_check_requests
is always true. Remove it.
yes kvmppc_core_flush_tlb() is defined in e500_mmu.c which is unconditionally linked in
both e500 config (kvm-e500mc-objs and kvm-e500-objs)
Nice catch. Thanks for the patch

Queued via PPC tree.

Maddy


Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
---
arch/powerpc/kvm/booke.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index fd7f24a68b31..ba762ac1fb56 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -738,10 +738,8 @@ int kvmppc_core_check_requests(struct kvm_vcpu *vcpu)
if (kvm_check_request(KVM_REQ_PENDING_TIMER, vcpu))
update_timer_ints(vcpu);
-#if defined(CONFIG_KVM_E500V2) || defined(CONFIG_KVM_E500MC)
if (kvm_check_request(KVM_REQ_TLB_FLUSH, vcpu))
kvmppc_core_flush_tlb(vcpu);
-#endif
if (kvm_check_request(KVM_REQ_WATCHDOG, vcpu)) {
vcpu->run->exit_reason = KVM_EXIT_WATCHDOG;