Re: [PATCH] MIPS: Fix genex.S build with LLVM before 21
From: Tzu-Ching Yang
Date: Sat Nov 21 2026 - 23:06:17 EST
Sorry for the late reply: your mail did not reach my mailbox, and I did
not check the list archive until now.
On Wed, 4 Nov 2026, Maciej W. Rozycki wrote:
> Shouldn't this use:
>
> Cc: <stable@xxxxxxxxxxxxxxx> # 6.6.x: 56651128e2fb: MIPS: Fix idle VS timer enqueue
> Cc: <stable@xxxxxxxxxxxxxxx> # 6.6.x: 2b6d718c8dbe: MIPS: Fix whitespace damage in r4k_wait from VS timer fix
> Cc: <stable@xxxxxxxxxxxxxxx> # 6.6.x
>
> then to get this all picked up?
Yes, with one more prerequisite after 56651128e2fb: b713f27e32d8
("MIPS: Move r4k_wait() to .cpuidle.text section"). I will send v2
with it added to your tags.
56651128e2fb adds a .previous after END(r4k_wait), and the .section
that it pairs with only comes with b713f27e32d8. With only your three
tags, on 6.12.118 and 6.6.162, all the code after r4k_wait in genex.S,
handle_int and the other exception handlers included, is placed in
.init.text, and a malta kernel hangs under QEMU about when the init
memory is freed.
With the four tags, the cherry-picks and this patch apply cleanly on
both trees. For malta_defconfig, genex.o builds with GCC 8.1 and 16.2
and with LLVM 13.0.1, 17.0.1 and 21.1.8 (on 6.6.162 also 11.1.0), and
kernels built with GCC 16.2 and LLVM 17.0.1 boot under QEMU. On 6.1.y
and older, 56651128e2fb conflicts in idle.c, so 6.6.x is as far back
as the cherry-picks apply cleanly.
> Or is it unsupported annotation syntax
> where a prerequisite matches a Fixes: tag?
It has worked before: the prerequisite named by 4409df5866b7 is
its Fixes: target, and 6.1.76 and 6.6.15 took both.
Thanks,
Tzu-Ching