Re: [PATCH net-next v9 03/11] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

From: Andrew Lunn

Date: Tue Oct 20 2026 - 15:31:30 EST


On Tue, Oct 20, 2026 at 04:48:48PM +0000, Selvamani Rajagopal wrote:
> Andrew, Jakub (and other concerned reviewers).
>
> This following feedback about change of module name is being raised regularly. While I understand
> the concern (and I agree with it), this is how it has been from the beginning and I didn't see any
> concern from the reviewers. So, I thought it is ok to leave it the way it is.
>
> My question is, should I change the module name back to the original oa_tc6.ko (from
> oa_tc6_mod.ko that is used in this patch series). If I choose to do that, original file name oa_tc6.c
> would have to change to oa_tc6_core.c or something like that.

I don't think we consider module names ABI.

However, some distros, especially in the embedded space such as yocto,
do make use of the module name, it produces a binary RPM named from
the module name. So if a rename can be avoided, that would be great.

Git is pretty good at following renames, so renaming oa_tc6.c to
oa_tc6_core.c in order to keep the module name the same should not
cause problems.

Andrew