RE: [PATCH net-next v9 03/11] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory
From: Selvamani Rajagopal
Date: Tue Oct 20 2026 - 13:02:27 EST
Andrew, Jakub (and other concerned reviewers).
This following feedback about change of module name is being raised regularly. While I understand
the concern (and I agree with it), this is how it has been from the beginning and I didn't see any
concern from the reviewers. So, I thought it is ok to leave it the way it is.
My question is, should I change the module name back to the original oa_tc6.ko (from
oa_tc6_mod.ko that is used in this patch series). If I choose to do that, original file name oa_tc6.c
would have to change to oa_tc6_core.c or something like that.
Sincerely
Selva
> -----Original Message-----
> From: netdev-bot+sashiko@xxxxxxxxxx <netdev-bot+sashiko@xxxxxxxxxx>
> Sent: Saturday, October 10, 2026 12:40 PM
> Subject: Re: [PATCH net-next v9 03/11] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory
>
>
>
> - [Medium] The commit message presents this as a pure file move ("Move
> oa_tc6.c to its own directory", similarity index 100%), but the patch…
>
>
> [Severity: Medium]
> Does this change the name of the module? Before this patch, the parent
> Makefile had:
>
> obj-$(CONFIG_OA_TC6) += oa_tc6.o
>
> That built oa_tc6.ko. With the composite target here, CONFIG_OA_TC6=m
> builds oa_tc6_mod.ko instead, and KBUILD_MODNAME becomes "oa_tc6_mod".
>
pw-bot: cr