Re: [PATCH v3 0/2] Add support for SA8255P in the phy-qcom-snps-femto-v2 phy driver

[Manivannan Sadhasivam]

On Thu, Oct 15, 2026 at 04:24:03PM +0200, Mattijs Korpershoek wrote:
> Hi Mani,
> 
> On Fri, Oct 02, 2026 at 11:41, Mattijs Korpershoek <mkorpershoek@xxxxxxxxxx> wrote:
> 
> > The Qualcomm automotive SA8255p SoC relies on firmware to configure
> > platform resources, including clocks, interconnects and TLMM.
> > The driver requests resources operations over SCMI using power protocols.
> >
> > The SCMI power protocol enables or disables resources like clocks,
> > interconnect paths, and TLMM (GPIOs) using runtime PM framework APIs,
> > such as resume/suspend, to control power on/off.
> >
> > Power domain "core" controls the GDSC, resets, and TLMM (GPIOs)
> > whereas power domain "transfer" controls clocks and interconnects.
> >
> > Patch 1 adds the binding for sa8255p. Similarly to what has been done
> > for I2C [1], this is a separate binding.
> >
> > Patch 2 adds the driver change, which is based on a public vendor
> > patch from qualcomm [2].
> > I did the following changes on top of that:
> > * Use devm_add_action_or_reset() for dev_pm_domain_detach_list() instead
> >   of implementing a driver .remove()
> > * Changed power domain names to drop 'usb_' prefix
> > * Fixed various error handling paths
> > * Added suspend/resume support
> >
> > This has been tested on next-20260728 with a Ride4 SA8775P board that
> > has SCMI firmware (which is compatible).
> >
> > [1] https://lore.kernel.org/all/20260617-enable-i2c-on-sa8255p-v7-1-ad736dbeab57@xxxxxxxxxxxxxxxx/
> > [2] https://git.codelinaro.org/clo/le/meta-qti-auto-kernel/-/blob/LY.AU.0.1.0.r1-16800-gen4meta.0/recipes-kernel/linux/files/usb/0014-PENDING-phy-qcom-snps-femto-v2-Add-support-for-SA825.patch
> >
> > Signed-off-by: Mattijs Korpershoek <mkorpershoek@xxxxxxxxxx>
> 
> I don't know what happened but somehow I did not add you in To/Cc using
> "b4 prep -c"
>

No worries.
 
> I've talked to Vinod at plumbers and he told me that I should request
> some review on these phy patches.
> 
> Could you have a look whenever you have some time?
> 

Sure thing. This series is on my queue. Will get to it very soon.

- Mani

-- 
மணிவண்ணன் சதாசிவம்