Re: [PATCH] mm/damon/reclaim: improve grammar and style

[SJ Park]

On Thu, 15 Oct 2026 10:06:23 +0200 Manuel Ebner <manuelebnerli@xxxxxxxxxxx> wrote:

> Fix tenses. Replace 'set as' with 'set to'.
> Rewrite complex sentences.

Let's put two sentences in one line, while breaking it for the 75 column limit.

[...]
> @@ -113,8 +113,8 @@ quota_sz
>  
>  Limit of size of memory for the reclamation in bytes.
>  
> -DAMON_RECLAIM charges amount of memory which it tried to reclaim within a time
> -window (quota_reset_interval_ms) and makes no more than this limit is tried.
> +DAMON_RECLAIM recordes the amount of memory which it tried to reclaim within a time

s/recordes/charges/  or s/recordes/records/ ?

I'd prefer charges, but my English is definitely bad, so looking for your
suggestion.

> +window (quota_reset_interval_ms) and stops when this memory limit is reached.

I feel like readers might wonder what is stopped.  How about "stops trying
reclaiming memory when ..." ?

>  This can be used for limiting consumption of CPU and IO.  If this value is
>  zero, the limit is disabled.
>  
> @@ -125,19 +125,19 @@ quota_reset_interval_ms
>  
>  The time/size quota charge reset interval in milliseconds.
>  
> -The charge reset interval for the quota of time (quota_ms) and size
> -(quota_sz).  That is, DAMON_RECLAIM does not try reclamation for more than
> +The quota reset interval of time is quota_ms and of size is
> +quota_sz.  That is, DAMON_RECLAIM does not try reclamation for more than

I think this change is just wrong?  quota_ms is not quota reset interval of
time.  Which part of the original sentence was difficult to read?

>  quota_ms milliseconds or quota_sz bytes within quota_reset_interval_ms
>  milliseconds.
>  
> -1 second by default.
> +1000 (1 second) by default.

Isn't this (1 second in milliseconds is 1,000) easy enough to infer for
readers?

>  
>  quota_mem_pressure_us
>  ---------------------
>  
>  Desired level of memory pressure-stall time in microseconds.
>  
> -While keeping the caps that set by other quotas, DAMON_RECLAIM automatically
> +While keeping the caps set by other quotas, DAMON_RECLAIM automatically

How about "caps that are set by ..." ?

>  increases and decreases the effective level of the quota aiming this level of
>  memory pressure is incurred.  System-wide ``some`` memory PSI in microseconds
>  per quota reset interval (``quota_reset_interval_ms``) is collected and


Thanks,
SJ

[...]