Re: [PATCH 1/1] dmaengine: shdma: move shdma_chan and shdma_desc structs to private header

From: Andy Shevchenko

Date: Tue Oct 13 2026 - 19:16:56 EST


On Tue, Oct 13, 2026 at 04:34:23PM -0400, Frank.Li@xxxxxxxxxxx wrote:

> Move struct shdma_chan and struct shdma_desc from the public header
> include/linux/shdma-base.h into the driver-private header
> drivers/dma/sh/shdma.h. These structs are only used internally by the
> shdma driver and do not need to be exposed to external users.
>
> Prepare to make struct dma_async_tx_descriptor private.

This kind of changes I like!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko