Re: [PATCH 1/1] dmaengine: shdma: move shdma_chan and shdma_desc structs to private header

From: Randy Dunlap

Date: Tue Oct 13 2026 - 17:13:39 EST




On 10/13/26 1:34 PM, Frank.Li@xxxxxxxxxxx wrote:
> From: Frank Li <Frank.Li@xxxxxxx>
>
> Move struct shdma_chan and struct shdma_desc from the public header
> include/linux/shdma-base.h into the driver-private header
> drivers/dma/sh/shdma.h. These structs are only used internally by the
> shdma driver and do not need to be exposed to external users.
>
> Prepare to make struct dma_async_tx_descriptor private.
>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks.

> ---
> drivers/dma/sh/shdma-base.c | 2 +-
> drivers/dma/sh/shdma.h | 80 +++++++++++++++++++++++++++++++++++++
> include/linux/shdma-base.h | 80 +------------------------------------
> 3 files changed, 83 insertions(+), 79 deletions(-)

--
~Randy