Re: [RFC PATCH kernel 02/17] pci/tsm: Fix stale comment about TDI report range start

[Bjorn Helgaas]

On Wed, Sep 16, 2026 at 09:51:42PM +1000, Alexey Kardashevskiy wrote:
> The PCIe spec r6 and later defines the MMIO range start in 4K units which
> was not the intention. The upcoming change makes it a byte address.
> The structure is already fixed to match the new definition but the comment
> is stale, fix it.

Please include specific reference to current spec, e.g.,
"PCIe r7.0, sec x".

I'm not sure who's intention is referred to here.

Please make the subject line match others in drivers/pci in style,
including capitalization.  Use "git log --oneline drivers/pci" to see.

> Signed-off-by: Alexey Kardashevskiy <aik@xxxxxxx>
> ---
>  drivers/pci/tsm/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/tsm/core.c b/drivers/pci/tsm/core.c
> index 9ac216ad896d..2a18be5be56e 100644
> --- a/drivers/pci/tsm/core.c
> +++ b/drivers/pci/tsm/core.c
> @@ -623,7 +623,6 @@ EXPORT_SYMBOL_GPL(pci_tsm_mmio_teardown);
>  #define PCI_TSM_DEVIF_REPORT_MMIO_ATTR_IS_UPDATABLE BIT(3)
>  #define PCI_TSM_DEVIF_REPORT_MMIO_ATTR_RANGE_ID GENMASK(31, 16)
>  
> -/* An interface report 'pfn' is 4K in size */
>  struct pci_tsm_devif_mmio {
>  	__le64 phys;
>  	__le32 nr_pfns;
> -- 
> 2.55.0
>