Re: [PATCH v2 00/11] media: i2c: st-vd55g1: Genericize driver and add VD55G0 support

[Sergey Lebedev]

Peter,

Benjamin suggested we get in touch, so: hello, and I should have written
first. I missed this series when it went out - I was not on the Cc and I
was not reading the list for work next to my own - and on 20 September I
sent ST a separate vd55g0.c off-list, two days after you posted, without
mentioning that somebody was already doing it here. That one is mine.

Two things are yours to take wherever the driver ends up.

The illuminator, your 05/11. GPIO 1 is right, and it can be measured
rather than assumed. Each GPIO was strobed in turn on a Surface Pro 11
(Intel), watched at the bezel through a phone camera by a person
counting, then measured as frame brightness against recorded timestamps:

  GPIO 0   strobe on 19.74   off 19.76   -0.02
  GPIO 1   strobe on 51.93   off 40.97  +10.96
  GPIO 2   strobe on 19.51   off 19.51   +0.00
  GPIO 3   strobe on 22.53   off 24.87   -2.34

and three cycles of GPIO 1 alone with the others held off:
117.95/115.60/117.71 lit against 21.51/22.06/24.43 dark. Take it for the
commit message if it helps - somebody will ask why 1, and "assume"
invites the question.

Hardware. You tested on a Surface Pro 9 with IPU6; this is a Surface Pro
11 for Business (Intel) with IPU7, where the part is the infrared camera.
Say the word and v2 goes on it.

Your 01-05 are exactly the parts I do not have and would otherwise be
writing - ipu-bridge, int3472, the illuminator - and Benjamin has said he
will take them. If those land beside a vd55g0.c then the machine works,
which is a better end than either of us starting again.

It is not my file to give away, but if you want a share of the driver -
writing part of it, a maintainer line, or taking it over outright - say
so now rather than after it is posted. You were here first, and you have
hardware I do not.

Sergey