Re: [PATCH 2/2] nvmem: layouts: onie-tlv: fix device_node reference leak in error path
From: Srinivas Kandagatla
Date: Sun Sep 20 2026 - 12:58:37 EST
On Tue, 11 Aug 2026 20:55:50 +0800, Leo Cheng wrote:
> onie_tlv_add_cells() takes a reference on the child node via
> of_get_child_by_name() for each parsed TLV and passes it to
> nvmem_add_one_cell() as cell.np. On success the created cell entry
> adopts that reference and releases it later via of_node_put(); on
> failure nvmem_add_one_cell() does not consume it, so the caller still
> owns it, but the error path only puts layout before returning, leaking
> the child node reference.
>
> [...]
Applied, thanks!
[2/2] nvmem: layouts: onie-tlv: fix device_node reference leak in error path
commit: aff113334732214b151c1aa0a69352ab569d8764
Best regards,
--
Srinivas Kandagatla <srini@xxxxxxxxxx>