Re: [PATCH 1/2] nvmem: layouts: sl28vpd: fix device_node reference leak in error path
From: Srinivas Kandagatla
Date: Sun Sep 20 2026 - 12:58:16 EST
On Tue, 11 Aug 2026 20:55:48 +0800, Leo Cheng wrote:
> sl28vpd_add_cells() takes a reference on the child node via
> of_get_child_by_name() for each entry and passes it to
> nvmem_add_one_cell() as info.np. On success the created cell entry
> adopts that reference and releases it later via of_node_put() when the
> entry is torn down; nvmem_add_one_cell() does not take its own
> reference. On failure it does not consume the reference either, so the
> caller still owns it, but the error path only puts layout_np before
> returning, leaking the child node reference.
>
> [...]
Applied, thanks!
[1/2] nvmem: layouts: sl28vpd: fix device_node reference leak in error path
commit: 885c33944796ec7ddf6b7babfc0f0710f66bfce3
Best regards,
--
Srinivas Kandagatla <srini@xxxxxxxxxx>