RE: [PATCH v2 1/2] dt-bindings: pps: pps-gpio: document optional pinctrl states

From: Farber, Eliav

Date: Thu Sep 17 2026 - 03:50:09 EST


On 16/09/2026, Rodolfo Giometti wrote:
>> + back to their alternate function. As "inactive" is the state to restore
>> + after "default", it may only appear as the second entry.
>
> The driver looks the states up by name, not by index, and only requires
> that "default" exists. Why you say that?

You're right, that was wrong. The driver looks both states up by name
(pinctrl_lookup_state()), so "inactive" can be at any index; it only
requires that a "default" state also exists. I'll drop the "second
entry" wording.

>> + minItems: 1
>> + items:
>> + - const: default
>> + - const: inactive
>
> AFAIK the tuple rules out ["default", "sleep"] and ["init", "default"]
> for good, and this is ABI.

Agreed, the tuple is too strict and would bake that in. In v3 I drop it
and only assert that a "default" state is present:

minItems: 1
contains:
const: default

so ["default", "sleep"], ["init", "default"], etc. all remain valid, and
the description just notes that an optional "inactive" state, if present,
requires "default" and may appear in any position.

Thanks,
Eliav