Re: [PATCH v2 1/2] dt-bindings: pps: pps-gpio: document optional pinctrl states

[Rodolfo Giometti]

On 16/09/2026 20:26, Eliav Farber wrote:
> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.yaml b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> index 383a838744eb..7d11ec4656ee 100644
> --- a/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> @@ -28,6 +28,19 @@ properties:
>      description: Indicates a falling edge assert, when present. Rising edge if absent.
>      type: boolean
>  
> +  pinctrl-names:
> +    description:
> +      When the PPS input is muxed through a pin controller, the "default"
> +      state selects the PPS/GPIO function and is applied by the driver core
> +      before probe. The optional "inactive" state, when present, is selected
> +      when the driver is unbound or the system is shut down, handing the pins
> +      back to their alternate function. As "inactive" is the state to restore
> +      after "default", it may only appear as the second entry.

The driver looks the states up by name, not by index, and only
requires that "default" exists. Why you say that?

> +    minItems: 1
> +    items:
> +      - const: default
> +      - const: inactive

AFAIK the tuple rules out ["default", "sleep"] and ["init", "default"]
for good, and this is ABI.

> +
>  required:
>    - compatible
>    - gpios
> @@ -40,8 +53,9 @@ examples:
>  
>      pps {
>          compatible = "pps-gpio";
> -        pinctrl-names = "default";
> +        pinctrl-names = "default", "inactive";
>          pinctrl-0 = <&pinctrl_pps>;
> +        pinctrl-1 = <&pinctrl_pps_inactive>;
>          gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
>          assert-falling-edge;
>          echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;

Ciao,

Rodolfo