Re: [PATCH v2 12/13] s390/qdio_setup: Use kzalloc() for the SSQD request

From: Heiko Carstens

Date: Wed Sep 16 2026 - 05:38:02 EST


On Thu, Sep 10, 2026 at 02:00:14PM +0300, Mike Rapoport (Microsoft) wrote:
> qdio_setup_get_ssqd() allocates the request block for the Store
> Subchannel QDIO Data (SSQD) CHSC command.
...
> diff --git a/drivers/s390/cio/qdio_setup.c b/drivers/s390/cio/qdio_setup.c
> index 7ca8f61a2387b..c0215a7d29a81 100644
> --- a/drivers/s390/cio/qdio_setup.c
> +++ b/drivers/s390/cio/qdio_setup.c
> @@ -249,7 +249,7 @@ int qdio_setup_get_ssqd(struct qdio_irq *irq_ptr,
>
> DBF_EVENT("getssqd:%4x", schid->sch_no);
> if (!irq_ptr) {
> - ssqd = (struct chsc_ssqd_area *)__get_free_page(GFP_KERNEL);
> + ssqd = kzalloc(PAGE_SIZE, GFP_KERNEL);

Same here. The conversion should change the allocation to kmalloc()
not kzalloc().