Re: [PATCH] net: qrtr: resend HELLO on MHI resume

[Thorsten Leemhuis]

On 9/16/26 05:09, Jeff Johnson wrote:
> On 9/15/2026 3:48 AM, Vlastimil Babka wrote:
>> On 9/11/26 12:44, Manivannan Sadhasivam wrote:
>>> On Wed, Sep 09, 2026 at 01:58:44PM +0800, Daniel J Blueman wrote:
>>>> Since the MHI HELLO exchange was relocated, it is sent only at device
>>>> registration. During a suspend-resume cycle, the firmware in WiFi
>>>> cards such as WCN7850 indefinitely waits for another HELLO,
>>>> triggering:
>>>> [...]
>>>> Fixes: 544d85de4dc2 ("net: qrtr: Send HELLO message on endpoint register")
>>>> Signed-off-by: Daniel J Blueman <daniel@xxxxxxxxx>
>>>> [...]
>>>> diff --git a/net/qrtr/af_qrtr.c b/net/qrtr/af_qrtr.c
>>>> index 78347c937af7..2ffcfc2fdb4a 100644
>>>> --- a/net/qrtr/af_qrtr.c
>>>> +++ b/net/qrtr/af_qrtr.c
>>>> @@ -623,6 +623,19 @@ static void qrtr_hello_work(struct work_struct *work)
>>>>  	qrtr_port_put(ctrl);
>>>>  }
>>>>  
>>>> +/* Trigger the HELLO handshake after the remote has been reset, eg on resume */
>>>
>>> Use proper kernel-doc please.
>
>> Please prioritize merging this sooner than later (it's a regression from
>> 7.3-rc2 that would hit people if it made it to 7.3 final) even if it means
>> fixing up non-critical aspects later, or by maintainer upon merging.
> 
> Concur. I recently fast-forwarded my ath tree and picked up the buggy commit,
> so everyone using my tree is now affected.

I wonder if we need somebody (Daniel?) to repost this patch to at least
have a chance to get it into the next -rc, as I didn't find the fix in
netdev's patchwork when I just looked -- maybe I missed something, but I
guess that's because the patch wasn't CCed to netdev.

Ciao, Thorsten

> And just want to point out that many of the function comments in this file do
> not use kernel-doc format, so I would not consider that a blocker. But it also
> would be trivial for the maintainer to add.
> 
> I've tested this on my HP ZBook 14 where I've replaced the OEM Wi-Fi adapter
> with WCN7850...
> 
> Tested-by: Jeff Johnson <jeff.johnson@xxxxxxxxxxxxxxxx>
> 
> /jeff
>