Re: [PATCH] Nova: Move register definition into module using it

[Alexandre Courbot]

Hi Antonin, thanks for this first patch!

Note about the subject: if you look at patches under
`drivers/gpu/nova-core`, you will notice that they all use the same
prefix (`gpu: nova-core:`). Here since you touch the `gsp` module,
you'll want to refine it further to `gpu: nova-core: gsp:`.

On Sun May 17, 2026 at 1:14 AM JST, Antonin Malzieu Ridolfi wrote:
> First babystep to split the register definitions grouped in nova root
> register file to the module which actually use them.

nit: "first babystep" is irrelevant for the git history, we prefer to
keep the log strictly factual. If you want to add side-comments, you can
do so after the `---` marker - these won't be picked up when the patch
is applied.

>
> Suggested-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> Suggested-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> Signed-off-by: Antonin Malzieu Ridolfi <dev@xxxxxxxxxxx>
> ---
>  drivers/gpu/nova-core/gsp.rs      |  1 +
>  drivers/gpu/nova-core/gsp/cmdq.rs |  3 ++-
>  drivers/gpu/nova-core/gsp/regs.rs | 11 +++++++++++
>  drivers/gpu/nova-core/regs.rs     |  8 --------
>  4 files changed, 14 insertions(+), 9 deletions(-)
>  create mode 100644 drivers/gpu/nova-core/gsp/regs.rs

The patch in itself looks exactly like expected. The reduced visibility
is definitely nice.

I suppose you will want to send a v2 addressing this feedback; feel free
to include one or more extra obvious modules as additional patches if
you feel like it. This is the kind of rework that can be merged quickly.