Re: [PATCH v3 03/27] rust: driver: decouple driver private data from driver type

From: Gary Guo

Date: Tue May 19 2026 - 08:52:46 EST


On Sun May 17, 2026 at 3:32 PM BST, Danilo Krummrich wrote:
> On Sun May 17, 2026 at 2:00 AM CEST, Danilo Krummrich wrote:
> > diff --git a/rust/kernel/driver.rs b/rust/kernel/driver.rs
> > index 586091cfa45c..3506b4e8bff9 100644
> > --- a/rust/kernel/driver.rs
> > +++ b/rust/kernel/driver.rs
> > @@ -17,6 +17,9 @@
> > //! /// The type holding information about each device ID supported by the driver.
> > //! type IdInfo: 'static;
> > //!
> > +//! /// The type of the driver's bus device private data.
> > +//! type Data;
>
> Should be:
>
> @@ -13,10 +13,13 @@
> //! The main driver interface is defined by a bus specific driver trait. For instance:
> //!
> //! ```ignore
> -//! pub trait Driver: Send {
> +//! pub trait Driver {
> //! /// The type holding information about each device ID supported by the driver.
> //! type IdInfo: 'static;
> //!
> +//! /// The type of the driver's bus device private data.
> +//! type Data: Send;
>

Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>

With this fix applied.

Best,
Gary