Re: [PATCH v2 1/2] iio: light: veml6030: fix channel type when pushing events

From: Jonathan Cameron

Date: Sat May 16 2026 - 09:09:23 EST


On Thu, 14 May 2026 14:01:11 +1300
Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:

> The events are registered for IIO_LIGHT and not for IIO_INTENSITY.
> Use the correct channel type.
>
> When at it, fix minor checkpatch code style warning (alignment).
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Applied this one to the fixes-togreg branch of iio.git.

Thanks

Jonathan

> ---
> drivers/iio/light/veml6030.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
> index 6bcacae3863c..da8c32cabfd6 100644
> --- a/drivers/iio/light/veml6030.c
> +++ b/drivers/iio/light/veml6030.c
> @@ -875,9 +875,11 @@ static irqreturn_t veml6030_event_handler(int irq, void *private)
> else
> evtdir = IIO_EV_DIR_FALLING;
>
> - iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_INTENSITY,
> - 0, IIO_EV_TYPE_THRESH, evtdir),
> - iio_get_time_ns(indio_dev));
> + iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_LIGHT,
> + 0,
> + IIO_EV_TYPE_THRESH,
> + evtdir),
> + iio_get_time_ns(indio_dev));
>
> return IRQ_HANDLED;
> }
>