Re: [PATCH v2 2/2] iio: light: veml6030: remove unnecessary read of IT index

[Jonathan Cameron]

On Thu, 14 May 2026 14:01:12 +1300
Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:

> This is dead code as the IT index is not used by gts to set the new scale.
> In its current form, the value is read but not used afterward. Remove
> the dead code.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Dropped previous version and picked this up instead.

Thanks,

Jonathan

> ---
>  drivers/iio/light/veml6030.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
> index da8c32cabfd6..2f9a25d59b71 100644
> --- a/drivers/iio/light/veml6030.c
> +++ b/drivers/iio/light/veml6030.c
> @@ -521,13 +521,9 @@ static int veml6030_write_persistence(struct iio_dev *indio_dev,
>  
>  static int veml6030_set_scale(struct iio_dev *indio_dev, int val, int val2)
>  {
> -	int ret, gain_sel, it_idx, it_sel;
> +	int ret, gain_sel, it_sel;
>  	struct veml6030_data *data = iio_priv(indio_dev);
>  
> -	ret = regmap_field_read(data->rf.it, &it_idx);
> -	if (ret)
> -		return ret;
> -
>  	ret = iio_gts_find_gain_time_sel_for_scale(&data->gts, val, val2,
>  						   &gain_sel, &it_sel);
>  	if (ret)
>