Re: [PATCH v4] iio: adc: ad7192: replace usleep_range() with fsleep()

From: Jonathan Cameron

Date: Mon May 11 2026 - 12:24:38 EST


On Mon, 11 May 2026 16:28:39 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Mon, May 11, 2026 at 07:55:44AM +0500, Stepan Ionichev wrote:
> > The AD7192 datasheet (Rev. A, page 34, RESET section) says:
> > "When a reset is initiated, the user must allow a period of
> > 500 us before accessing any of the on-chip registers."
>
> > Use fsleep(500) instead of usleep_range(500, 1000). The 500 us
> > minimum stays the same; fsleep() picks the upper slack itself
> > (about +25% on a default config).
>
> The second sentence here...
>
> > Add a code comment with the datasheet reference so the "why"
> > of the wait is visible at the call site.
>
> ...and this paragraph are unneeded details.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>

Tweaked and applied.