Re: [PATCH 4/4] media: ipu-bridge: Add the Surface Pro 11 infrared illuminator
From: Sergey Lebedev
Date: Sun Oct 25 2026 - 13:23:44 EST
Hi Fernando,
On 25/10/2026 15:47, Fernando Rimoli wrote:
> The property entry keeps pointers to both its name and its values, and
> here both point into the module image: the "st,leds" literal and the
> static const surface_pro_11_ir_gpios[].
You are right, thank you. The only other name there that does not come
from the per-sensor prop_names copy is "lens-focus", which D. Manresa's
v4 moves as well. So v2 will do what your a20c843c9bc4 and his v4 do:
"st,leds" goes into struct ipu_property_names, and the GPIO numbers are
copied into struct ipu_sensor.
> Manresa's v4 1/2 changes this same line to use names->lens_focus, so
> whichever of the two lands second will need a rebase.
Noted; v2 will say so below the ---.
> The Surface Pro 9 needs an entry too. Its VD55G0 drives the illuminator
> from GPIO 1, as on your machine.
v2 will add it, matching the sys_vendor and product_name you give
exactly, as for the Surface Pro 11. I will Cc you; a run of v2 as posted
on the Surface Pro 9 would be welcome.
Sergey