Re: [PATCH 0/5] Add support for a TEE agnostic Inline Crypto Engine service

[Eric Biggers]

On Sun, Oct 25, 2026 at 10:16:49PM +0530, Harshal Dev wrote:
> By moving the TEE call re-direction to a separate middleware we are ensuring
> that we only touch the 9-10 lines in the driver which depend on the TEE firmware.
> Merging this functionality in the ICE driver would substantially increases
> the total file size.

Again, it would be simpler to handle it directly in the existing
qcom_ice module.  Yes, there will then be more code in that module, but
then the new single-user middleware module wouldn't be needed.

> This is why probe always defers if this check fails:
> https://elixir.bootlin.com/linux/v7.3/source/drivers/soc/qcom/ice.c#L568

Nope, it's:

	if (!qcom_scm_is_available())
		return ERR_PTR(-EPROBE_DEFER);

	if (!qcom_scm_ice_available()) {
		dev_warn(dev, "ICE SCM interface not found\n");
		return ERR_PTR(-EOPNOTSUPP);
	}

So if SCM is not available at all then the probe is deferred.  But if
just the ICE interface is unavailable then UFS or eMMC comes up without
ICE support.  This series regresses the latter fallback behavior.

- Eric