Re: [PATCH 2/2] iio: imu: Add driver for the ADI ADIS16607

[Uwe Kleine-König]

On Thu, Oct 01, 2026 at 12:11:50PM +0300, Radu Sabau via B4 Relay wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/spi/spi.h>

Please don't use <linux/mod_devicetable.h>. <linux/spi/spi.h> is good
enough to provide spi_device_id and of_device_id already.

> +static const struct spi_device_id adis16607_id[] = {
> +	{ "adis16607-2", (kernel_ulong_t)&adis16607_2_chip_info },
> +	{ "adis16607-3", (kernel_ulong_t)&adis16607_3_chip_info },
> +	{ }

Please use named initializers, i.e.

	{ .name = "adis16607-2", .driver_data = (kernel_ulong_t)&adis16607_2_chip_info },

> +};
> +MODULE_DEVICE_TABLE(spi, adis16607_id);
> +
> +static const struct of_device_id adis16607_of_match[] = {
> +	{ .compatible = "adi,adis16607-2", .data = &adis16607_2_chip_info },
> +	{ .compatible = "adi,adis16607-3", .data = &adis16607_3_chip_info },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, adis16607_of_match);
> +
> +static struct spi_driver adis16607_driver = {
> +	.driver = {
> +		.name = "adis16607",
> +		.of_match_table = adis16607_of_match,
> +	},
> +	.probe = adis16607_probe,
> +	.id_table = adis16607_id,
> +};
> +module_spi_driver(adis16607_driver);
> +
> +MODULE_AUTHOR("Radu Sabau <radu.sabau@xxxxxxxxxx>");
> +MODULE_DESCRIPTION("Analog Devices ADIS16607 IMU driver");
> +MODULE_IMPORT_NS("IIO_ADISLIB");
> +MODULE_LICENSE("GPL");
> 
> -- 
> 2.43.0
> 
>

Attachment: signature.asc
Description: PGP signature