Re: [PATCH 2/2] iio: imu: Add driver for the ADI ADIS16607
From: Andy Shevchenko
Date: Mon Oct 12 2026 - 07:21:21 EST
On Mon, Oct 12, 2026 at 2:12 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxx> wrote:
> On Thu, Oct 01, 2026 at 12:11:50PM +0300, Radu Sabau via B4 Relay wrote:
> > +#include <linux/mod_devicetable.h>
> > [...]
> > +#include <linux/spi/spi.h>
>
> Please don't use <linux/mod_devicetable.h>. <linux/spi/spi.h> is good
> enough to provide spi_device_id and of_device_id already.
On the same grounds as for OF, it has to provide the data type for ACPI as well.
All the same to i2c, platform_device and so on...
--
With Best Regards,
Andy Shevchenko