Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings

From: Dan Carpenter

Date: Wed Mar 25 2026 - 03:29:28 EST


There are a couple of different things happening here. The mentorship
program has its own rules. The rule that people should test their code
seems like a good rule.

In staging, most of the patches that we apply not tested. I assumed
this patch wasn't tested. Patches like this are not a big deal because
we can easily review them. Sometimes, patches change runtime so unless
it's a security issue, we want those to be tested.

>
> - if (0x00 == PathAOK) {
> - }
>

We normally wouldn't merge patches which do multiple things at once
but it doesn't really make sense to reverse this condition around since
it's dead code so to me it falls under the "related change" category.

regards,
dan carpenter