Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings

[Shuah Khan]

On 3/24/26 10:02, Prithvi wrote:
> On Tue, Mar 24, 2026 at 04:05:51PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 24, 2026 at 07:25:51PM +0530, Prithvi wrote:
> > > Sure. Also can you please guide if any testing would be required for these
> > > changes, or I can directly send the v3 patch?
> >
> > It's implied that the author of the patch each time before submission (either
> > a new version of the existing patch or a new patch in general) is tested and
> > validated it.

+1

> > --
> > With Best Regards,
> > Andy Shevchenko
>
> Understood. I agree that patch must be tested and validated every time.
>
> To be transparent, I do not have access to the physical Realtek hardware,
> so I am unable to perform runtime testing. However, for this v3, I have
> performed compile testing and ensured that the module builds correctly.
> Will this be acceptable for this patch?

No -  Hmm. Aren't you part of Fall mentorship program?

We discussed this several times during the program that when someone
sends a patch, it is implied that they tested the patch. Compile
testing isn't sufficient. The changes in this patch not trivial spelling
fixes in comments either.

 
-	if (1 <= channel && channel <= 14) {
+	if (channel >= 1 && channel <= 14) {

I picked just one and there are more like this one.

These aren't just moving the constant lies to the right side of the test,
they change logic and in some cases removing the code and the change log
doesn't say anything about that.

Did you look into if this conditional can just go away?

-	if (0x00 == PathAOK) {
-	}


I am not the maintainer for this, but as your mentor this isn't acceptable.
I wouldn't take this patch unless these changes are tested on the device.

thanks,
-- Shuah