Re: [PATCH] drm: fix dead default for DRM_TTM_KUNIT_TEST

[Christian König]

Hi Julian,

On 3/22/26 23:01, Julian Braha wrote:
> The DRM_TTM_KUNIT_TEST config option should default
> to KUNIT_ALL_TESTS so that if all tests are enabled then
> it is included, but currently the 'default KUNIT_ALL_TESTS'
> statement is shadowed by an unconditional 'default n',
> meaning that this second default statement is currently dead code.

I need to double check the discussion back then, but I think the tests were pretty beta when initially merged.

So it was intentionally to not include them automatically when KUNIT_ALL_TESTS is enabled.

We can probably do that since the tests are stable now, but I think we should definitely drop the Fixes tag.

Regards,
Christian.

> 
> This dead code was found by kconfirm, a static analysis
> tool for Kconfig.
> 
> Fixes: e3912d09bf8d ("drm/ttm: Introduce KUnit test")
> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
> ---
>  drivers/gpu/drm/Kconfig.debug | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/Kconfig.debug b/drivers/gpu/drm/Kconfig.debug
> index 05dc43c0b8c5..75c186f938b0 100644
> --- a/drivers/gpu/drm/Kconfig.debug
> +++ b/drivers/gpu/drm/Kconfig.debug
> @@ -86,7 +86,6 @@ config DRM_KUNIT_TEST
> 
>  config DRM_TTM_KUNIT_TEST
>         tristate "KUnit tests for TTM" if !KUNIT_ALL_TESTS
> -       default n
>         depends on DRM && KUNIT && MMU && (UML || COMPILE_TEST)
>         select DRM_TTM
>         select DRM_BUDDY
> --
> 2.51.2
>