Re: [PATCH v4 1/2] dt-bindings: embedded-controller: Add synology,microp device

[Markus Probst]

On Sat, 2026-03-21 at 13:32 +0100, Krzysztof Kozlowski wrote:
> On 21/03/2026 13:17, Markus Probst wrote:
> > On Sat, 2026-03-21 at 11:21 +0100, Krzysztof Kozlowski wrote:
> > > On Fri, Mar 20, 2026 at 11:09:53PM +0100, Markus Probst wrote:
> > > > +
> > > > +examples:
> > > > +  - |
> > > > +    #include <dt-bindings/leds/common.h>
> > > > +
> > > > +    embedded-controller {
> > > > +      compatible = "synology,microp";
> > > > +
> > > > +      power-led {
> > > > +        color = <LED_COLOR_ID_BLUE>;
> > > > +        function = LED_FUNCTION_POWER;
> > > > +      };
> > > > +
> > > > +      status-led {
> > > > +        color = <LED_COLOR_ID_MULTI>;
> > > > +        function = LED_FUNCTION_STATUS;
> > > > +      };
> > > 
> > > Where are other leds? Binding mentions 4.
> > > 
> > Status and Power leds exist on every Synology NAS model I am aware of.
> > But there are models which have additionally a usb or alert led. The
> > device nodes for those leds should only be present, if they exist
> > physically on the device.
> 
> Then help me to understand - are these different models?
Yes, even with different CPU architectures.
How much the "microp" device differs is not clear, but the
communication protocol is the same.
> 
> EC is not a generic purpose component and is tightly coupled with the
> actual board it is being present on. Unless exactly same board is used
> in different models (unlikely) then the compatible defines the LEDs and
> they are not needed in DT.
So for instance "synology,ds923p-microp", "synology,ds723p-microp" etc.
?

I can do that, but that would be many.
Having it generic seems more flexible.

> 
> I should have brought this earlier, so apologies for that.
> 
Thanks
- Markus Probst

> > 
> > > Does that mean that they
> > > differ on each device?  The EC is tied to specific model, so that would
> > > be surprising. And if they do not differ, what is exactly the point of
> > > describing the LEDs in DT?
> > The color of the leds is different on some models.
> > 
> > I suppose I should add this information to the description.
> > 
> 
> 
> Best regards,
> Krzysztof

Attachment: signature.asc
Description: This is a digitally signed message part