Re: [PATCH 0/5] mm: Switch gfp_t to unsigned long
From: Brendan Jackman
Date: Fri Mar 20 2026 - 05:38:04 EST
Human summary of Sashiko (AI) review [0]
[PATCH 2/5] iwlegacy: 3945-mac: Use special gfp_t format specifier
Just identifying pre-existing (and low-stakes) issues in the code. I
can add a patch to fix them up.
Andrew, I think it probably makes sense to merge these cleanup patches
regardless of the gfp_t change, as Zi said. Would you take them
through mm or would they need to go via the more specific branches?
[PATCH 5/5] mm: Change gfp_t to unsigned long
- 1 << __GFP_BITS_SHIFT needs to be updated to use 1UL.
- Need to update userspace tools like perf.
- Says I can't use unsigned long in module_param_unsafe(), which I
think is true. I did that to address a build failure, maybe I never
actually repeated the build?
Other patches got a green tick.
[0] https://sashiko.dev/#/patchset/20260319-gfp64-v1-0-2c73b8d42b7f%40google.com