Re: [PATCH v3 04/12] scsi: ufs: core: Add support for TX Equalization

[Peter Wang (王信友)]

On Thu, 2026-03-19 at 13:49 +0800, Can Guo wrote:
> Sure, for the lanes too. But I will still keep FOM records as u16,
> because we
> need to initialize it to a default value other than 0x0 to 0xFF such
> that we
> can differentiate a real FOM value (unit 8, read from RX_FOM) from
> the
> default one.
> 
> Thanks,
> Can Guo.
> 

Hi Can,

It seems keeping UINT16 is only for dumping this line.
	if (fom == 0xFFFFFFFF)
		seq_printf(s, "%8s%s", "-", " ");

if the default scan covers all supported preshoot and
deemphasis values, should the FOM value always be set based
on the actual hardware reading and thus bypass the initial 
value check for FOM?
Furthermore, if use_txeq_presets is true, could you simply
dump only 8 values and bypass the check if FOM is at its 
initial value?

Thanks.
Peter