Re: [PATCH v3 04/12] scsi: ufs: core: Add support for TX Equalization

[Can Guo]

On 3/17/2026 9:10 PM, Peter Wang (王信友) wrote:
> On Tue, 2026-03-17 at 15:35 +0800, Can Guo wrote:
> > The main data struct which is costing memory is the TX EQTR record
> > arrays, I can optimize
> > in next very by dynamically allocating memory ONLY for the Gears
> > which
> > actually
> > need TX EQTR.
> > 
> > Thanks,
> > Can Guo.
> > > 
>
> Hi Can,
>
> It's not just Gear that needs to be considered, lane count does
> as well. Only allocate the Gear and lane numbers that actually
> require EQTR. Also, please optimize the structure, for variables
> that only need UINT8, don't use UINT32, since memory usage is four
> times greater.
Sure, for the lanes too. But I will still keep FOM records as u16, 
because we
need to initialize it to a default value other than 0x0 to 0xFF such that we
can differentiate a real FOM value (unit 8, read from RX_FOM) from the
default one.

Thanks,
Can Guo.
> Thanks
> Peter
>
> ************* MEDIATEK Confidentiality Notice ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!