Re: [PATCH] net: mvpp2: guard flow control update with global_tx_fc in buffer switching
From: patchwork-bot+netdevbpf
Date: Thu Mar 19 2026 - 06:01:57 EST
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@xxxxxxxxxx>:
On Mon, 16 Mar 2026 12:31:01 -0700 you wrote:
> mvpp2_bm_switch_buffers() unconditionally calls
> mvpp2_bm_pool_update_priv_fc() when switching between per-cpu and
> shared buffer pool modes. This function programs CM3 flow control
> registers via mvpp2_cm3_read()/mvpp2_cm3_write(), which dereference
> priv->cm3_base without any NULL check.
>
> When the CM3 SRAM resource is not present in the device tree (the
> third reg entry added by commit 60523583b07c ("dts: marvell: add CM3
> SRAM memory to cp11x ethernet device tree")), priv->cm3_base remains
> NULL and priv->global_tx_fc is false. Any operation that triggers
> mvpp2_bm_switch_buffers(), for example an MTU change that crosses
> the jumbo frame threshold, will crash:
>
> [...]
Here is the summary with links:
- net: mvpp2: guard flow control update with global_tx_fc in buffer switching
https://git.kernel.org/netdev/net/c/8a63baadf084
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html