Re: [PATCH v3 1/2] printk: add print_hex_dump_devel()

[John Ogness]

On 2026-03-19, John Ogness <john.ogness@xxxxxxxxxxxxx> wrote:
>> +#define print_hex_dump_devel(prefix_str, prefix_type, rowsize,		\
>> +			     groupsize, buf, len, ascii)		\
>> +	print_hex_dump(KERN_DEBUG, prefix_str, prefix_type, rowsize,	\
>> +		       groupsize, buf, len, ascii)
>> +#else
>> +static inline void print_hex_dump_devel(const char *prefix_str, int prefix_type,
>> +					int rowsize, int groupsize,
>> +					const void *buf, size_t len, bool ascii)
>> +{
>> +}
>
> If you look at the implementation of pr_devel(), it is using no_printk()
> in the !DEBUG case. I believe this is to validate correct arg
> formatting, even if the code will optimized out.

Sorry, print_hex_dump() has no printf formatting.

Reviewed-by: John Ogness <john.ogness@xxxxxxxxxxxxx>