Re: [PATCH v4 03/10] clk: realtek: Add basic reset support

From: Krzysztof Kozlowski

Date: Tue Mar 17 2026 - 03:15:05 EST


On 17/03/2026 03:12, Yu-Chun Lin [林祐君] wrote:
>>> diff --git a/drivers/clk/realtek/reset.c b/drivers/clk/realtek/reset.c
>>> new file mode 100644 index 000000000000..45713785d76d
>>> --- /dev/null
>>> +++ b/drivers/clk/realtek/reset.c
>>> @@ -0,0 +1,104 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * Copyright (C) 2019 Realtek Semiconductor Corporation */
>>> +
>>> +#include <linux/device.h>
>>> +#include <linux/of.h>
>>> +#include <linux/regmap.h>
>>> +#include "reset.h"
>>
>> And here is the proof that none of your reset header constants are bindings -
>> do you see the header here above? No.
>>
>
> The bank mapping is implicitly hardcoded in drivers:

Does not matter. Here is the proof this is not a binding.

Best regards,
Krzysztof