Re: [PATCH spi-next 04/11] spi: spi-fsl-lpspi: fsl_lpspi_set_watermark(): use FIELD_PREP() to encode FIFO Status register

[Mark Brown]

On Mon, Mar 16, 2026 at 09:39:05AM +0100, Marc Kleine-Budde wrote:

> +#define FCR_RXWATER	GENMASK(18, 16)
> +#define FCR_TXWATER	GENMASK(2, 0)

The source of the watermark values appears to be

	temp = readl(fsl_lpspi->base + IMX7ULP_PARAM);
	fsl_lpspi->txfifosize = 1 << (temp & 0x0f);
	fsl_lpspi->rxfifosize = 1 << ((temp >> 8) & 0x0f);

which suggests 4 bits of watermark not 3?  Or at least that something
isn't joined up somewhere.

Attachment: signature.asc
Description: PGP signature