Re: [PATCH v2 1/3] dt-bindings: clock: amlogic: Fix redundant hyphen in "amlogic,t7-gp1--pll" string.
From: Jian Hu
Date: Mon Mar 16 2026 - 08:22:28 EST
On 3/14/2026 5:53 PM, Krzysztof Kozlowski wrote:
[ EXTERNAL EMAIL ]
On Fri, Mar 13, 2026 at 03:00:20PM +0800, Jian Hu wrote:
Fix redundant hyphen in "amlogic,t7-gp1--pll" string.Incorrect DCO chain. I don't understand what Ronald's SoB is doing here.
Fixes: 5437753728ac ("dt-bindings: clock: add Amlogic T7 PLL clock controller")
Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx>
Signed-off-by: Ronald Claveau <linux-kernel-dev@xxxxxxxx>
Please read submitting patches document to understand how various tags
are used in Linux kernel.
Thanks for the your review, my apologies for not clarifying Ronald's contribution clearly in the cover letter.
Ronald's "Add EMMC for T7 khadas VIM4" serial patches found it and reported it.[1]
His patches intended to enable EMMC DT, but it depends on the T7 Clock controller.
It includes the fixed clocks, sys clocks dt-bindings and drivers, But these SCMI clock driver are done in the SCP firmware.[2]
The Amlogic T7 clocks controller DT should be enabled then he can enable his work.
I sorted his clock fixing typo patch,submitted together with the fixing missing mpll3 patch and T7 clock
controller DT which I have confirmed with him. The third patch depends on the second patch.
So I submitted them separately.
His patch also submited some T7 clock controller DT nodes, I added his SoB in the third patch, too.
So Could I add his SoB here or other tags like Co-developed-by for patch 1 and patch 3?
Also I will document the history in next cover letter.
[1] https://patchwork.kernel.org/project/linux-amlogic/patch/20260218101904.35541-1-linux-kernel-dev@xxxxxxxx/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/dt-bindings/clock/amlogic,t7-scmi.h
Best regards,
Krzysztof