Re: [PATCH 1/3] media: qcom: camss: x1e80100: Fix CSID2 routing to nowhere

From: Loic Poulain

Date: Sun Nov 22 2026 - 14:51:19 EST


On Sun, Nov 22, 2026 at 3:10 AM <bryan.odonoghue@xxxxxxxxxx> wrote:
>
> From: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>
> CSID2 doesn't actually have a corresponding VFE it can receive CSIPHY input
> and raise an interrupt but it can't drive any VFE write-master. This is
> basically useless and not worth coding around in the upstream driver. If we
> find a real use for this we can turn this back on. In the meantime drop the
> definition, it only confuses things.
>
> Fixes: 1830cf0f56c3 ("media: qcom: camss: Add x1e80100 specific support")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>

> ---
> drivers/media/platform/qcom/camss/camss.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 26e3f2aa3ef24..aa6d01d8fcb2a 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -4515,27 +4515,6 @@ static const struct camss_subdev_resources csid_res_x1e80100[] = {
> .formats = &csid_formats_gen2
> },
> },
> - /* CSID2 */
> - {
> - .regulators = {},
> - .clock = { "gcc_axi_hf", "gcc_axi_sf", "cpas_ahb",
> - "cpas_fast_ahb", "csid", "csid_csiphy_rx" },
> - .clock_rate = { { 0 },
> - { 0 },
> - { 64000000, 80000000 },
> - { 80000000, 100000000, 200000000,
> - 300000000, 400000000 },
> - { 300000000, 400000000, 480000000 },
> - { 300000000, 400000000, 480000000 }, },
> - .reg = { "csid2" },
> - .interrupt = { "csid2" },
> - .csid = {
> - .frame_sync_en = true,
> - .hw_ops = &csid_ops_680,
> - .parent_dev_ops = &vfe_parent_dev_ops,
> - .formats = &csid_formats_gen2
> - },
> - },
> /* CSID_LITE0 */
> {
> .regulators = {},
>
> --
> 2.56.0
>