Re: [PATCH 0/3] media: qcom: camss: Two routing fixes and one tidy-up

From: Gjorgji Rosikopulos (Consultant)

Date: Sun Nov 22 2026 - 14:03:22 EST


Hi Bryan,

Thanks for the fixes.

For the whole series:

Reviewed-by: Gjorgji Rosikopulos <gjorgji.rosikopulos@xxxxxxxxxxxxxxxx>

On 11/22/2026 4:10 AM, bryan.odonoghue@xxxxxxxxxx wrote:
> This series lands late-enough in the kernel cycle and applies against the
> camss-next branch staging to linux-media/next.
>
> Link: https://gitlab.freedesktop.org/linux-media/users/bodonoghue/-/tree/camss-next
>
> First up a patch drops the declaration of CSID2 from x1e/Hamoa since this
> CSID doesn't have a corresponding VFE it is entirely useless and violates
> our 1:1 mapping between VFE and CSID. Since CSID2 routes nowhere there's no
> reason to keep it around.
>
> Second is a fix for a longstanding error in CAMSS which as stemmed from
> the original development of post ISPIF devices. These devices have a 1:1
> mapping between CSID and VFE so the mapping we have given to user-space
> which declares each CSID as connecting to each VFE is just plain wrong on
> these devices and has always been.
>
> So the second patch addresses that longstanding issue but, I've been
> holding off on fixing this for a while since I believed it might require
> extensive surgery, but in the end its quite simple to do.
>
> Finally the third patch is a tidy-up patch which inverts our current logic
> of continuously adding new elements to the src_pad_code switch for new SoCs
> filtering those SoCs down to a default: statement. In fact is is the old
> SoCs which are the exceptional case so, just do the switch for the old and
> the default for the new.
>
> Signed-off-by: Bryan O'Donoghue <bod@xxxxxxxxxx>
> ---
> Bryan O'Donoghue (3):
> media: qcom: camss: x1e80100: Fix CSID2 routing to nowhere
> media: qcom: camss: Fix CSID to VFE routing for non ISPIF platforms
> media: qcom: camss: vfe: Eliminate ever expanding src_pad_code switch logic
>
> drivers/media/platform/qcom/camss/camss-vfe.c | 20 +--------
> drivers/media/platform/qcom/camss/camss.c | 59 ++++++++++-----------------
> 2 files changed, 23 insertions(+), 56 deletions(-)
> ---
> base-commit: 2ad58ca589da80990b7afbcff018777851577f89
> change-id: 20261122-camss-routing-fixes-b178bdb84f20
>
> Best regards,
> --
> ---
> bod