Re: [PATCH v2 2/8] ARM: dts: rockchip: Add support for RK3506

From: Andrew Lunn

Date: Sun Nov 22 2026 - 13:25:03 EST


On Sun, Nov 22, 2026 at 05:01:08PM +0100, Jonas Karlman wrote:
> Hi Andrew,
>
> On 11/22/2026 4:46 PM, Andrew Lunn wrote:
> >> diff --git a/arch/arm/boot/dts/rockchip/rk3506.dtsi b/arch/arm/boot/dts/rockchip/rk3506.dtsi
> >
> >> + gmac0: ethernet@ff4c8000 {
> >> + compatible = "rockchip,rk3506-gmac", "snps,dwmac-4.20a";
> >> + reg = <0xff4c8000 0x2000>;
> >> + clocks = <&cru CLK_MAC0>, <&cru CLK_MAC0_PTP>,
> >> + <&cru PCLK_MAC0>, <&cru ACLK_MAC0>;
> >> + clock-names = "stmmaceth", "ptp_ref",
> >> + "pclk_mac", "aclk_mac";
> >> + interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>,
> >> + <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> >> + interrupt-names = "macirq", "eth_wake_irq";
> >> + phy-mode = "rmii";
> >
> > Sorry, missed this on the first pass of the patchset.
> >
> > phy-mode is generally a board/PCB property, not a SoC property. It
> > would only be a SoC property when the SoC cannot do anything other
> > than RMII. But given this is snps,dwmac, i expect it can do other phy
> > modes.
>
> This SoC only support RMII mode, so I put the phy-mode at SoC level.
>
> Datasheet for this SoC lists following:
>
> RMII 10/100 Ethernet Controller
> - Support two Ethernet Controllers
> - Supports 10/100-Mbps data transfer rates with the RMII interfaces
> - Supports both full-duplex and half-duplex operation
>
> The Technical Reference Manual also only mention RMII:
>
> 38.2 Block Diagram
> ...
> The MAC only supports the PHY interfaces of reduced MII (RMII).
> ...
> MAC Supports 10/100-Mbps data transfer rates with the RMII interfaces.

That is unusual, but O.K.

For the Ethernet node only:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew