Re: [PATCH v3 1/4] dt-bindings: mailbox: Add AMD PL Mailbox IP

From: Krzysztof Kozlowski

Date: Sun Nov 22 2026 - 12:08:47 EST


On Thu, Nov 19, 2026 at 02:04:02PM -0800, Ben Levinsky wrote:
> Add a binding for the AMD PL Mailbox, a soft IP used to exchange 32-bit
> words between two processors through a pair of FIFOs.
>
> The IP lives in programmable logic and isn't tied to a SoC, so the
> compatible names the IP and its version. The FIFO depth is set when the
> design is synthesized and can't be read from the hardware, hence
> property amd,pl-mailbox-depth.
>
> Assisted-by: Claude:claude-opus-5.5

Drop, wasn't even here before, so you must have added it.
https://lore.kernel.org/all/20261014213426.2957480-6-ben.levinsky@xxxxxxx/

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

> Signed-off-by: Ben Levinsky <ben.levinsky@xxxxxxx>
> ---
> .../bindings/mailbox/amd,pl-mailbox-2.1.yaml | 71 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 77 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/amd,pl-mailbox-2.1.yaml
>
> diff --git a/Documentation/devicetree/bindings/mailbox/amd,pl-mailbox-2.1.yaml b/Documentation/devicetree/bindings/mailbox/amd,pl-mailbox-2.1.yaml
> new file mode 100644
> index 000000000000..50ac14a4cbac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/amd,pl-mailbox-2.1.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mailbox/amd,pl-mailbox-2.1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMD Programmable Logic Mailbox IP
> +
> +maintainers:
> + - Ben Levinsky <ben.levinsky@xxxxxxx>
> +
> +description: |
> + The AMD Programmable Logic Mailbox IP passes messages between two
> + processors through a pair of FIFOs. Each side of the IP has its own
> + registers, interrupt and clock, and is described by its own node.
> + Channel 0 is used to transmit and channel 1 to receive.
> +
> + The Mailbox is a soft IP core instantiated in programmable logic, not a
> + SoC block, so the compatible names the IP core and its version (2.1).
> + The "pl" part distinguishes it from the IPI hardware that can also be
> + used as a mailbox.
> +
> +properties:
> + compatible:
> + const: amd,pl-mailbox-2.1
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + amd,pl-mailbox-depth:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 16
> + maximum: 8192
> + default: 16
> + description:
> + Depth of the send and receive FIFOs in 32-bit words. The depth is the
> + C_MAILBOX_DEPTH parameter chosen for each IP instance when the design
> + is synthesized, so instances in one design can differ, and it cannot
> + be read from the registers. Must match the synthesized depth.
> +
> + '#mbox-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - '#mbox-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + mailbox@b2060000 {
> + compatible = "amd,pl-mailbox-2.1";
> + reg = <0xb2060000 0x10000>;
> + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&pl_clk>;
> + amd,pl-mailbox-depth = <16>;
> + #mbox-cells = <1>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ca1c59e1fc59..dc6a835f7bbc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1315,6 +1315,12 @@ S: Supported
> T: git https://gitlab.freedesktop.org/agd5f/linux.git
> F: drivers/gpu/drm/amd/pm/
>
> +AMD PROGRAMMABLE LOGIC MAILBOX DRIVER
> +M: Ben Levinsky <ben.levinsky@xxxxxxx>
> +L: linux-kernel@xxxxxxxxxxxxxxx

Drop list, there is no point in mentioning lkml for every driver. lkml
is standard list, catch all.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof