Re: [PATCH v3 1/2] dt-bindings: media: qcom,glymur-camss: Use linear CSI ports
From: Krzysztof Kozlowski
Date: Sun Nov 22 2026 - 12:06:15 EST
On Thu, Nov 19, 2026 at 08:34:22PM +0530, Nihal Kumar Gupta wrote:
> Glymur has three CSI2 PHY connections: CSIPHY0, CSIPHY1 and CSIPHY4.
> The existing ABI used port@3 for CSIPHY4 because the driver reused the
> X1E80100 CSIPHY table, where entry 3 maps to hardware PHY id 4.
>
> Use linear graph ports 0-2 by replacing port@3 with port@2 for the third
> CSI2 PHY connection. The matching Glymur driver data maps port@2 to
> hardware PHY id 4, and there are no in-tree users of the old port@3 ABI
> yet.
There is in-tree user - I clearly see camss.c. Your next patch even
changes that user!
This is just not correct :/
Anyway, mark it as fixes and be explicit that you target CURRENT RC. Or
was this already a released ABI?
Best regards,
Krzysztof