Re: [PATCH v6 4/4] selftests/mm: test fork of PMD-mapped shmem THPs

From: David Hildenbrand (Arm)

Date: Sun Nov 22 2026 - 11:52:50 EST


On 11/19/26 14:44, Konstantin Khorenko wrote:
> Fork a process that maps shmem THPs with PMDs, in a VMA whose page
> tables fork copies: a private mapping with an anon_vma, and a shared
> one with a guard region. The child must find the PMDs before it
> touches the mapping, and its exit must leave the parent's mapping and
> the system-wide ShmemPmdMapped counter as they were.
>
> With folio_dup_file_rmap_pmd() adding PTE mappings, the child's exit
> takes the parent's share off ShmemPmdMapped while the parent still maps
> the folios. Unmapping them drops it once more, so every mapping stays
> until exit, where the kernel reports "Bad page cache", or hits a
> VM_BUG_ON with CONFIG_DEBUG_VM. A kernel that leaves file THPs to a
> refault in the child skips the test.
>
> ShmemPmdMapped is system-wide, and reclaim or NUMA balancing can take a
> PMD from the parent while the test runs. So the test makes up to three
> attempts, each on a fresh file, and fails only if all of them see the
> counter drop by exactly the parent's share: the bug does that on every
> fork, other processes only by chance. It passes on the first clean
> attempt and skips when none is clean.
>
> The test mounts a tmpfs with huge=always over /tmp in a private mount
> namespace, so it leaves the THP settings and the host's mounts and
> files alone.
>
> Signed-off-by: Konstantin Khorenko <khorenko@xxxxxxxxxxxxx>
> ---
> MAINTAINERS | 1 +
> tools/testing/selftests/mm/Makefile | 1 +
> tools/testing/selftests/mm/fork_file_thp.c | 256 +++++++++++++++++++++++++++++
> tools/testing/selftests/mm/run_vmtests.sh | 1 +
> 4 files changed, 259 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d738990161bd0..7ade132e3d3ab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17941,6 +17941,7 @@ F: mm/huge_memory.c
> F: mm/khugepaged.c
> F: mm/mm_slot.h
> F: tools/mm/thpmaps
> +F: tools/testing/selftests/mm/fork_file_thp.c
> F: tools/testing/selftests/mm/khugepaged.c
> F: tools/testing/selftests/mm/split_huge_page_test.c
> F: tools/testing/selftests/mm/transhuge-stress.c
> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
> index 0ea72e9979347..2489027b2a36b 100644
> --- a/tools/testing/selftests/mm/Makefile
> +++ b/tools/testing/selftests/mm/Makefile
> @@ -108,6 +108,7 @@ TEST_GEN_FILES += folio_split_race_test
> TEST_GEN_FILES += folio_order_check
> TEST_GEN_FILES += khugepaged_sync_check
> TEST_GEN_FILES += khugepaged_race
> +TEST_GEN_FILES += fork_file_thp
> TEST_GEN_FILES += soft-dirty
>
> ifeq ($(ARCH),x86_64)
> diff --git a/tools/testing/selftests/mm/fork_file_thp.c b/tools/testing/selftests/mm/fork_file_thp.c
> new file mode 100644
> index 0000000000000..aaecf7ba6f406
> --- /dev/null
> +++ b/tools/testing/selftests/mm/fork_file_thp.c
> @@ -0,0 +1,256 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * fork() of a process that maps shmem THPs with PMDs, in a VMA whose page
> + * tables fork copies: a private mapping with an anon_vma, and a shared
> + * mapping with a guard region.
> + *
> + * The child must get the PMDs without faulting, and its exit must leave the
> + * parent's mapping and the system-wide ShmemPmdMapped counter as they were.
> + * Kernels that leave file THPs to a refault in the child skip the test.
> + */
> +#define _GNU_SOURCE
> +#include <asm-generic/mman.h> /* Force the import of the tools version. */
> +#include <errno.h>
> +#include <fcntl.h>
> +#include <stdbool.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <unistd.h>
> +#include <sched.h>
> +#include <sys/mman.h>
> +#include <sys/mount.h>
> +#include <sys/wait.h>
> +
> +#include "kselftest.h"
> +#include "vm_util.h"
> +
> +#define NR_PMDS 4
> +#define MAX_PMDSIZE (32UL << 20)
> +/* Other processes, reclaim and NUMA balancing can disturb an attempt. */
> +#define ATTEMPTS 3
> +
> +static size_t pagesize, pmdsize, size;
> +
> +static long meminfo_kb(const char *key)
> +{
> + char line[256];
> + long kb = -1;
> + FILE *f = fopen("/proc/meminfo", "r");
> +
> + if (!f)
> + return -1;
> + while (fgets(line, sizeof(line), f))
> + if (!strncmp(line, key, strlen(key))) {
> + kb = strtol(line + strlen(key), NULL, 10);
> + break;
> + }
> + fclose(f);
> + return kb;
> +}
> +
> +/* Skips the last page, which may be a guard page, and @skip. */
> +static bool data_ok(const char *mem, size_t skip)
> +{
> + size_t off;
> +
> + for (off = 0; off < size - pagesize; off += pagesize)
> + if (off != skip && mem[off] != (char)(off / pmdsize + 1))
> + return false;
> + return true;
> +}
> +
> +/* The last PMD is zapped by the setup, the others must be PMD-mapped. */
> +static bool pmds_ok(char *mem)
> +{
> + return check_huge_file(mem, size - pmdsize, NR_PMDS - 1, pmdsize);
> +}
> +
> +/* Maps a fresh shmem file of NR_PMDS PMDs, PMD-aligned, until exit. */
> +static char *map_file(bool shared)
> +{
> + char *area, *buf, *mem;
> + size_t off;
> + int fd;
> +
> + fd = open("/tmp/fork_file_thp", O_RDWR | O_CREAT | O_TRUNC, 0600);
> + if (fd < 0)
> + ksft_exit_fail_perror("open");
> + unlink("/tmp/fork_file_thp");
> + buf = malloc(pmdsize);
> + if (!buf)
> + ksft_exit_fail_msg("malloc failed\n");
> + for (off = 0; off < size; off += pmdsize) {
> + memset(buf, off / pmdsize + 1, pmdsize);
> + if (pwrite(fd, buf, pmdsize, off) != (ssize_t)pmdsize)
> + ksft_exit_fail_perror("pwrite");
> + }
> + free(buf);
> +
> + area = mmap(NULL, size + pmdsize, PROT_NONE,
> + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
> + if (area == MAP_FAILED)
> + ksft_exit_fail_perror("mmap");
> + mem = (char *)(((unsigned long)area + pmdsize - 1) & ~(pmdsize - 1));
> + mem = mmap(mem, size, PROT_READ | PROT_WRITE,
> + (shared ? MAP_SHARED : MAP_PRIVATE) | MAP_FIXED, fd, 0);
> + if (mem == MAP_FAILED)
> + ksft_exit_fail_perror("mmap");
> + close(fd);
> + for (off = 0; off < size; off += pmdsize)
> + FORCE_READ(mem[off]);
> + return mem;
> +}
> +
> +/* Child exit codes, apart from what kselftest helpers exit with. */
> +enum result { PASS, NO_PMDS = 10, FAIL_DATA, FAIL_COUNTER, FAIL_PARENT,
> + FAIL_KILLED, COUNTER_OFF, CHANGED, LOST_PMDS, NO_THP };
> +
> +static enum result fork_once(char *mem, bool shared, long *before, long *after)
> +{
> + /* The parent alone maps this much with PMDs. */
> + long own = (NR_PMDS - 1) * (pmdsize >> 10);
> + bool parent_pmds;
> + int status;
> + pid_t pid;
> +
> + *before = *after = meminfo_kb("ShmemPmdMapped:");

That's not how we test for PMD mappings from other code.

We have check_huge_file() etc helpers in vm_util.c for that.


Further, some things look a bit odd, like:

+static void test_fork(bool shared)
+{
+ const char *desc = shared ? "shared mapping with a guard region" :
+ "private mapping with an anon_vma";

Why guard regions? Why boolean parameters?

This selftest should probably be written using the kselftest harness instead.

BUT I am not convinced the selftest as is is worth it. It check for too too
detailed corner cases.

I think we'd want something fairly simple, nothing the does detailed accounting
checks.

I'll queue 1-3 for now, thanks!

--
Cheers,

David