[PATCH net-next v4 0/3] net: phy: dap8211r: add LED control support

From: Artem Shimko

Date: Sun Nov 22 2026 - 08:19:28 EST


Hello,

This series adds support for LEDs on the DAP8211R
Gigabit Ethernet PHY.

The first patch fixes mistakes in function comments about locking mdio.
The second patch documents the optional "leds" node in the Device Tree
binding.
The third patch introduces a small helper to write extended
registers, since the LED registers are accessed indirectly via
EXT_ADD/EXT_DATA and implements the three LED callbacks
required by the PHY library.

$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
SCHEMA Documentation/devicetree/bindings/processed-schema.json
CHKDT ./Documentation/devicetree/bindings
LINT ./Documentation/devicetree/bindings
STYLE ./Documentation/devicetree/bindings
DTEX Documentation/devicetree/bindings/net/dptel,dap8211r.example.dts
DTC [C] Documentation/devicetree/bindings/net/dptel,dap8211r.example.dtb
$ yamllint Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
$ grep -i "dap8211r" Documentation/devicetree/bindings/processed-schema.json
"http://devicetree.org/schemas/net/dptel,dap8211r.yaml": {
"$filename": "/home/a-shimko/patchwork/linux/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml",
"$id": "http://devicetree.org/schemas/net/dptel,dap8211r.yaml#";,
"title": "DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY",

Required:
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=y
CONFIG_LEDS_TRIGGERS=y
CONFIG_LEDS_TRIGGER_NETDEV=y

Testing:
$ ip link set eth1 up
$ ls /sys/class/leds/
stmmac-1:01:amber:lan stmmac-1:01:green:lan
$ echo netdev > /sys/class/leds/stmmac-1:01:green:lan/trigger
$ echo eth1 > /sys/class/leds/stmmac-1:01:green:lan/device_name
$ echo 1 > /sys/class/leds/stmmac-1:01:green:lan/link_1000
$ cat /sys/class/leds/stmmac-1:01:green:lan/offloaded
$ ip addr add 192.168.5.100/24 dev eth1
$ ping -I eth1 192.168.5.1

$ echo netdev > /sys/class/leds/stmmac-1:01:amber:lan/trigger
$ echo eth1 > /sys/class/leds/stmmac-1:01:amber:lan/device_name
$ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/tx
$ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/rx
$ cat /sys/class/leds/stmmac-1:01:amber:lan/offloaded

$ echo none > /sys/class/leds/stmmac-1:01:amber:lan/trigger
$ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/brightness

$ echo netdev > /sys/class/leds/stmmac-1:01:amber:lan/trigger
$ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/tx
$ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/rx
$ ip addr add 192.168.5.100/24 dev eth1
$ ping -I eth1 192.168.5.1

--
Best regards,
artem

ChangeLog:
v4:
- squash extended register write helper into the LED control patch to
fix netdev/build_32bit, netdev/build_allmodconfig_warn, netdev/build_clang
fails (patchwork.kernel.org)
- add andrew+netdev@xxxxxxx to Cc of dt-bindings patch to fix
netdev/cc_maintainers warning (patchwork.kernel.org)
v3:
- fix kernel-doc comment for DAP8211R_LED_FORCE_MODE_ON and
DAP8211R_LED_FORCE_MODE_MASK
- use FIELD_PREP() for DAP8211R_LED_FORCE_MODE_ON
- Link: https://lore.kernel.org/all/20261120081106.2919010-1-a.shimko.dev@xxxxxxxxx/T/#t
v2:
- add a commit fixing kernel-doc comments for dap8211r_read_ext() and dap8211r_modify_ext()
- move LED child node down below tx-internal-delay-ps in dptel,dap8211r.yaml
- add blank lines in dptel,dap8211r.yaml
- restrict LED reg index to 0..2 and fix schema properties in dptel,dap8211r.yaml
- fix kernel-doc comment for dap8211r_write_ext()
- add LED brightness (force mode) support to driver
- remove rules == 0 statement
- add TRIGGER_NETDEV_LINK to DAP8211R_LED_SUPPORTED_TRG for dap8211r_led_hw_is_supported()
- clean up switch (index) statements
- Link: https://lore.kernel.org/all/CAOPX74709XiLXLoioDJStTSzzhstC2sHpM4GieAO=3-37E18pw@xxxxxxxxxxxxxx/T/#u
v1:
- Link: https://lore.kernel.org/all/20261113110546.173624-1-a.shimko.dev@xxxxxxxxx/T/#t

Artem Shimko (3):
net: phy: dap8211r: fix kernel-doc comments for extended register
helpers
dt-bindings: net: dptel,dap8211r: add LED nodes
net: phy: dap8211r: add PHY LED control support

.../bindings/net/dptel,dap8211r.yaml | 50 ++++
drivers/net/phy/dap8211r.c | 242 +++++++++++++++++-
2 files changed, 290 insertions(+), 2 deletions(-)

--
2.43.0