Re: [PATCH 0/6] dyndbg,vmlinux.lds.h: fix i386 section alignment in BOUNDED_SECTION macros

From: David Laight

Date: Sun Nov 22 2026 - 07:02:20 EST


On Sat, 21 Nov 2026 15:49:18 -0700
Jim Cromie via B4 Relay <devnull+jim.cromie.gmail.com@xxxxxxxxxx> wrote:

> This series fixes a latent i386 section-alignment bug, by adding
> explicit alignments into the BOUNDED_SECTION_* linker script macros.
> The misalignment appears once __dyndbg_classes is split in 2, and the
> 1st section has just 1 entry; the 2nd section implicitly gets ALIGN(4).

Would everything work if all these sections got an ALIGN(8)?
It would simplify everything and only cost a few bytes of memory
that no one is really going to notice.

(Apart from BTF which seems to be page aligned.)

David

>
> 1. Refactor BOUNDED_SECTION_* (and HEADERED_SECTION_*) macros from
> vmlinux.lds.h into include/asm-generic/bounded_sections.lds.h for
> reuse.
>
> 2. Drop the unused HEADERED_SECTION* macros from bounded_sections.lds.h.
>
> 3. Add explicit ALIGN(8) defaults to BOUNDED_SECTION_* (with _ALIGNED
> variants for non-8-byte tables like ORC_UNWIND_TABLE,
> EXCEPTION_TABLE, TRACEDATA, INIT_SETUP, and NOTES), fixing an i386
> NULL deref in dynamic_debug_init() caused by 28-byte
> __dyndbg_classes misaligning the following __dyndbg section.
>
> 4. Remove now-redundant outer `. = ALIGN(8);` directives preceding
> BOUNDED_SECTION* uses in vmlinux.lds.h.
>
> 5. Add include/asm-generic/dyndbg.lds.h with DYNDBG_SECTIONS() for
> vmlinux.lds.h and MOD_DYNDBG_SECTIONS() (`0 : ALIGN(8)` + `KEEP`) for
> scripts/module.lds.S, fixing lost __dyndbg* sections in DRM modules
> under CONFIG_DRM_USE_DYNAMIC_DEBUG=y.
>
> 6. fix checkpatch to skip macro-rules checks on any *.lds.h, in 3
> places where only vmlinux.lds.h is currently skipped.
>
> NB: most of this patchset was split out of larger series fixing
> dyndbg-classmaps.
>
> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
> ---
> Jim Cromie (6):
> vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h
> vmlinux.lds.h: drop unused HEADERED_SECTION* macros
> vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386
> vmlinux.lds.h: remove redundant ALIGN(8) directives
> dyndbg.lds.S: fix lost dyndbg sections in modules
> checkpatch.pl: generalize linker script macro exceptions
>
> MAINTAINERS | 1 +
> include/asm-generic/bounded_sections.lds.h | 32 ++++++++++++++
> include/asm-generic/dyndbg.lds.h | 18 ++++++++
> include/asm-generic/vmlinux.lds.h | 68 ++++++------------------------
> scripts/checkpatch.pl | 6 +--
> scripts/module.lds.S | 2 +
> 6 files changed, 69 insertions(+), 58 deletions(-)
> ---
> base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
> change-id: 20261121-vmlinux-lds-b59410146885
>
> Best regards,