[PATCH 3/3] cpufreq: s5pv210: Fix resource leaks on probe error paths
From: Suyuan Wang via B4 Relay
Date: Sun Nov 22 2026 - 06:55:43 EST
From: Suyuan Wang <stevewong@xxxxxxxxxxx>
s5pv210_cpufreq_probe() returns the result of cpufreq_register_driver()
directly:
register_reboot_notifier(&s5pv210_cpufreq_reboot_notifier);
return cpufreq_register_driver(&s5pv210_driver);
If the registration fails, for example because s5pv210_cpu_init()
fails, the resources taken by the probe itself are leaked: the two
regulators and the clock and DMC register mappings. The reboot notifier
also stays registered. (s5pv210_cpu_init() releases its own clocks on
its error paths, and the cpufreq core tears down its own state.)
Also, when a DMC node has a bad alias, the code jumps to err_clk_base
and skips unmapping DMC registers that were already mapped for an
earlier node.
Unregister the reboot notifier and go through the existing unwind code
when cpufreq_register_driver() fails, and jump to err_dmc on the alias
error. The err_clk_base label has no users after this, so drop it.
Found with a static analysis tool and checked by hand.
Fixes: 6d4ed0f46af6 ("cpufreq: s5pv210: Make the driver multiplatform aware")
Fixes: e0e5b2b4f427 ("cpufreq: s5pv210: Defer probe if getting regulators fail")
Co-developed-by: Kaixuan Li <kaixuan.li@xxxxxxxxxx>
Signed-off-by: Kaixuan Li <kaixuan.li@xxxxxxxxxx>
Signed-off-by: Suyuan Wang <stevewong@xxxxxxxxxxx>
---
drivers/cpufreq/s5pv210-cpufreq.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index e64e84e1ee79..29b1c5d71a8b 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -634,7 +634,7 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev)
if (id < 0 || id >= ARRAY_SIZE(dmc_base)) {
dev_err(dev, "failed to get alias of dmc node '%pOFn'\n", dmc);
result = id;
- goto err_clk_base;
+ goto err_dmc;
}
dmc_base[id] = of_iomap(dmc, 0);
@@ -655,7 +655,14 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev)
register_reboot_notifier(&s5pv210_cpufreq_reboot_notifier);
- return cpufreq_register_driver(&s5pv210_driver);
+ result = cpufreq_register_driver(&s5pv210_driver);
+ if (result)
+ goto err_reboot_notifier;
+
+ return 0;
+
+err_reboot_notifier:
+ unregister_reboot_notifier(&s5pv210_cpufreq_reboot_notifier);
err_dmc:
for (id = 0; id < ARRAY_SIZE(dmc_base); ++id)
@@ -664,7 +671,6 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev)
dmc_base[id] = NULL;
}
-err_clk_base:
iounmap(clk_base);
err_clock:
--
2.34.1