Re: [PATCH net 1/1] ipv6: fix MSG_SPLICE_PAGES with a dst trailer in __ip6_append_data()
From: Ido Schimmel
Date: Sun Nov 22 2026 - 06:33:54 EST
On Sun, Nov 22, 2026 at 07:24:07PM +0900, Kyuwon Cho wrote:
> When __ip6_append_data() starts a new skb for a fragment that is not
> the last one, it adds the dst's trailer_len to datalen. On the paged
> path pagedlen was computed before that, so with an xfrm dst
>
> copy = datalen - transhdrlen - fraggap - pagedlen;
>
> is trailer_len instead of 0. getfrag() copies those bytes from the
> message iterator, but the MSG_SPLICE_PAGES branch right after it also
> runs when getfrag() succeeds and resets copy to 0, so length is not
> reduced by the bytes just copied. On the next pass the splice branch
> finds copy larger than what is left in the iterator, warns and returns
> -EIO, so sendfile() of a UDPv6 datagram that needs fragmentation over
> an xfrm tunnel fails:
>
> WARNING: net/ipv6/ip6_output.c:1796 at __ip6_append_data+0x17ed/0x4b70
> RIP: 0010:__ip6_append_data (net/ipv6/ip6_output.c:1796)
> Call Trace:
> <TASK>
> ip6_make_skb (net/ipv6/ip6_output.c:2097)
> udpv6_sendmsg (net/ipv6/udp.c:1717)
> sock_sendmsg (net/socket.c:841)
> splice_to_socket (fs/splice.c:811)
> direct_splice_actor (fs/splice.c:863 fs/splice.c:1114)
> splice_direct_to_actor (fs/splice.c:1023)
> do_splice_direct (fs/splice.c:1157 fs/splice.c:1183)
> do_sendfile (fs/read_write.c:1351)
>
> IPv4 is not affected: __ip_append_data() does not add trailer_len to
> datalen.
>
> The branch was added by commit ce650a166335 ("udp6: Fix
> __ip6_append_data()'s handling of MSG_SPLICE_PAGES"), when copy could
> be negative on this path. Since commit 736b380e28d0 ("ipv6: account for
> fraggap on the paged allocation path") a negative copy returns -EINVAL
> before this point, so remove the branch.
>
> Fixes: ce650a166335 ("udp6: Fix __ip6_append_data()'s handling of MSG_SPLICE_PAGES")
> Signed-off-by: Kyuwon Cho <kyuwoncho18@xxxxxxxxx>
Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>