[PATCH v8 05/12] drm/panel: panel-lg-lh400wv3: Convert to mipi_dbi_write_seq_multi()
From: Svyatoslav Ryhel
Date: Sun Nov 22 2026 - 03:19:08 EST
Switch from the internal panel command-sending macro to a generic one to
improve code reuse.
Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
---
drivers/gpu/drm/panel/panel-lg-lh400wv3.c | 91 ++++++++++-------------
1 file changed, 40 insertions(+), 51 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-lg-lh400wv3.c b/drivers/gpu/drm/panel/panel-lg-lh400wv3.c
index 63efeb434be13..02150330f1735 100644
--- a/drivers/gpu/drm/panel/panel-lg-lh400wv3.c
+++ b/drivers/gpu/drm/panel/panel-lg-lh400wv3.c
@@ -37,19 +37,6 @@ static inline struct lg_lh400wv3 *to_lg_lh400wv3(struct drm_panel *panel)
return container_of(panel, struct lg_lh400wv3, panel);
}
-#define panel_dbi_command(priv, cmd, seq...) \
-({ \
- const u8 d[] = { seq }; \
- struct drm_panel *panel = &(priv)->panel; \
- struct mipi_dbi_device *dbidev = (priv)->dbidev; \
- struct device *dev = panel->dev; \
- int ret; \
- ret = mipi_dbi_command_stackbuf((dbidev)->dbi, cmd, d, ARRAY_SIZE(d)); \
- if (ret) \
- dev_err_ratelimited(dev, "error %d when sending command %#02x\n", ret, cmd); \
- ret; \
-})
-
static int lg_lh400wv3_prepare(struct drm_panel *panel)
{
struct lg_lh400wv3 *priv = to_lg_lh400wv3(panel);
@@ -76,57 +63,59 @@ static int lg_lh400wv3_prepare(struct drm_panel *panel)
static int lg_lh400wv3_enable(struct drm_panel *panel)
{
struct lg_lh400wv3 *priv = to_lg_lh400wv3(panel);
-
- panel_dbi_command(priv, MIPI_DCS_EXIT_INVERT_MODE);
- panel_dbi_command(priv, MIPI_DCS_SET_TEAR_ON);
-
- panel_dbi_command(priv, MIPI_DCS_SET_PIXEL_FORMAT, MIPI_DCS_PIXEL_FMT_24BIT |
- MIPI_DCS_PIXEL_FMT_24BIT << 4);
-
- panel_dbi_command(priv, 0xb2, 0x00, 0xc8);
- panel_dbi_command(priv, 0xb3, 0x00);
- panel_dbi_command(priv, 0xb4, 0x04);
- panel_dbi_command(priv, 0xb5, 0x42, 0x10, 0x10, 0x00, 0x20);
- panel_dbi_command(priv, 0xb6, 0x0b, 0x0f, 0x3c, 0x13, 0x13, 0xe8);
- panel_dbi_command(priv, 0xb7, 0x4c, 0x06, 0x0c, 0x00, 0x00);
-
- panel_dbi_command(priv, 0xc0, 0x01, 0x11);
- panel_dbi_command(priv, 0xc3, 0x07, 0x03, 0x04, 0x04, 0x04);
- panel_dbi_command(priv, 0xc4, 0x12, 0x24, 0x18, 0x18, 0x02, 0x49);
- panel_dbi_command(priv, 0xc5, 0x65);
- panel_dbi_command(priv, 0xc6, 0x41, 0x63);
-
- panel_dbi_command(priv, 0xd0, 0x00, 0x46, 0x74, 0x32, 0x1d, 0x03, 0x51, 0x15, 0x04);
- panel_dbi_command(priv, 0xd1, 0x00, 0x46, 0x74, 0x32, 0x1d, 0x03, 0x51, 0x15, 0x04);
- panel_dbi_command(priv, 0xd2, 0x00, 0x46, 0x74, 0x32, 0x1f, 0x03, 0x51, 0x15, 0x04);
- panel_dbi_command(priv, 0xd3, 0x00, 0x46, 0x74, 0x32, 0x1f, 0x03, 0x51, 0x15, 0x04);
- panel_dbi_command(priv, 0xd4, 0x01, 0x46, 0x74, 0x25, 0x00, 0x03, 0x51, 0x15, 0x04);
- panel_dbi_command(priv, 0xd5, 0x01, 0x46, 0x74, 0x25, 0x00, 0x03, 0x51, 0x15, 0x04);
-
- panel_dbi_command(priv, MIPI_DCS_SET_COLUMN_ADDRESS, 0x00, 0x00, 0x01, 0xdf);
- panel_dbi_command(priv, MIPI_DCS_SET_PAGE_ADDRESS, 0x00, 0x00, 0x03, 0x1f);
-
- panel_dbi_command(priv, MIPI_DCS_EXIT_SLEEP_MODE);
+ struct mipi_dbi_multi_context ctx = { .dbidev = priv->dbidev };
+
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_EXIT_INVERT_MODE);
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_SET_TEAR_ON);
+
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_SET_PIXEL_FORMAT, MIPI_DCS_PIXEL_FMT_24BIT |
+ MIPI_DCS_PIXEL_FMT_24BIT << 4);
+
+ mipi_dbi_write_seq_multi(&ctx, 0xb2, 0x00, 0xc8);
+ mipi_dbi_write_seq_multi(&ctx, 0xb3, 0x00);
+ mipi_dbi_write_seq_multi(&ctx, 0xb4, 0x04);
+ mipi_dbi_write_seq_multi(&ctx, 0xb5, 0x42, 0x10, 0x10, 0x00, 0x20);
+ mipi_dbi_write_seq_multi(&ctx, 0xb6, 0x0b, 0x0f, 0x3c, 0x13, 0x13, 0xe8);
+ mipi_dbi_write_seq_multi(&ctx, 0xb7, 0x4c, 0x06, 0x0c, 0x00, 0x00);
+
+ mipi_dbi_write_seq_multi(&ctx, 0xc0, 0x01, 0x11);
+ mipi_dbi_write_seq_multi(&ctx, 0xc3, 0x07, 0x03, 0x04, 0x04, 0x04);
+ mipi_dbi_write_seq_multi(&ctx, 0xc4, 0x12, 0x24, 0x18, 0x18, 0x02, 0x49);
+ mipi_dbi_write_seq_multi(&ctx, 0xc5, 0x65);
+ mipi_dbi_write_seq_multi(&ctx, 0xc6, 0x41, 0x63);
+
+ mipi_dbi_write_seq_multi(&ctx, 0xd0, 0x00, 0x46, 0x74, 0x32, 0x1d, 0x03, 0x51, 0x15, 0x04);
+ mipi_dbi_write_seq_multi(&ctx, 0xd1, 0x00, 0x46, 0x74, 0x32, 0x1d, 0x03, 0x51, 0x15, 0x04);
+ mipi_dbi_write_seq_multi(&ctx, 0xd2, 0x00, 0x46, 0x74, 0x32, 0x1f, 0x03, 0x51, 0x15, 0x04);
+ mipi_dbi_write_seq_multi(&ctx, 0xd3, 0x00, 0x46, 0x74, 0x32, 0x1f, 0x03, 0x51, 0x15, 0x04);
+ mipi_dbi_write_seq_multi(&ctx, 0xd4, 0x01, 0x46, 0x74, 0x25, 0x00, 0x03, 0x51, 0x15, 0x04);
+ mipi_dbi_write_seq_multi(&ctx, 0xd5, 0x01, 0x46, 0x74, 0x25, 0x00, 0x03, 0x51, 0x15, 0x04);
+
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_SET_COLUMN_ADDRESS, 0x00, 0x00, 0x01, 0xdf);
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_SET_PAGE_ADDRESS, 0x00, 0x00, 0x03, 0x1f);
+
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_EXIT_SLEEP_MODE);
msleep(120);
- panel_dbi_command(priv, MIPI_DCS_WRITE_MEMORY_START);
- panel_dbi_command(priv, MIPI_DCS_SET_DISPLAY_ON);
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_WRITE_MEMORY_START);
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_SET_DISPLAY_ON);
- return 0;
+ return ctx.accum_err;
}
static int lg_lh400wv3_disable(struct drm_panel *panel)
{
struct lg_lh400wv3 *priv = to_lg_lh400wv3(panel);
+ struct mipi_dbi_multi_context ctx = { .dbidev = priv->dbidev };
- panel_dbi_command(priv, MIPI_DCS_SET_DISPLAY_OFF);
- panel_dbi_command(priv, MIPI_DCS_ENTER_SLEEP_MODE);
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_SET_DISPLAY_OFF);
+ mipi_dbi_write_seq_multi(&ctx, MIPI_DCS_ENTER_SLEEP_MODE);
msleep(150);
- panel_dbi_command(priv, 0xc1, 0x01);
+ mipi_dbi_write_seq_multi(&ctx, 0xc1, 0x01);
usleep_range(10000, 11000);
- return 0;
+ return ctx.accum_err;
}
static int lg_lh400wv3_unprepare(struct drm_panel *panel)
--
2.53.0